Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creation timestamp to pre-detections #436

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Aug 22, 2023

The timestamp of pre-detections is the same as the timestamp of the event it was created from.
This change adds an additional creation_timestamp to pre-detections that shows when the pre-detection was created by Logprep.

@ppcad ppcad requested a review from dtrai2 August 22, 2023 10:56
@ppcad ppcad marked this pull request as ready for review September 19, 2023 05:57
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the changes. I only have two suggestions, one regarding the for-loop and could you also please add a CHANGELOG.md entry? Thank you!

logprep/processor/pre_detector/processor.py Outdated Show resolved Hide resolved
@dtrai2
Copy link
Collaborator

dtrai2 commented Sep 21, 2023

I am not really available for the next two weeks. @ekneg54 could you set the final approve after my changes are implemented?

@dtrai2 dtrai2 requested a review from ekneg54 September 21, 2023 13:19
@ppcad ppcad requested a review from dtrai2 September 22, 2023 05:37
@ppcad ppcad self-assigned this Sep 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (11f1442) 92.28% compared to head (f7a7497) 92.38%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   92.28%   92.38%   +0.09%     
==========================================
  Files         133      135       +2     
  Lines        9595     9541      -54     
==========================================
- Hits         8855     8814      -41     
+ Misses        740      727      -13     
Files Changed Coverage Δ
logprep/processor/pre_detector/processor.py 96.15% <100.00%> (+2.15%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 requested review from dtrai2 and removed request for dtrai2 September 25, 2023 07:21
@ekneg54 ekneg54 requested a review from dtrai2 September 25, 2023 07:23
@ekneg54 ekneg54 merged commit 80b9b41 into main Sep 25, 2023
10 checks passed
@ekneg54 ekneg54 deleted the dev-change-pre-detector-timestamps branch April 3, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants