-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add creation timestamp to pre-detections #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked the changes. I only have two suggestions, one regarding the for-loop and could you also please add a CHANGELOG.md entry? Thank you!
I am not really available for the next two weeks. @ekneg54 could you set the final approve after my changes are implemented? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 92.28% 92.38% +0.09%
==========================================
Files 133 135 +2
Lines 9595 9541 -54
==========================================
- Hits 8855 8814 -41
+ Misses 740 727 -13
☔ View full report in Codecov by Sentry. |
The timestamp of pre-detections is the same as the timestamp of the event it was created from.
This change adds an additional
creation_timestamp
to pre-detections that shows when the pre-detection was created by Logprep.