Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time_measurement for empty events after deleter deleted the event #437

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

dtrai2
Copy link
Collaborator

@dtrai2 dtrai2 commented Aug 23, 2023

Fix writing time measurements into the event after the deleter has deleted the event. The bug only
happened when the metrics.measure_time.append_to_event configuration was set to true.

@dtrai2 dtrai2 added the bug Something isn't working label Aug 23, 2023
@dtrai2 dtrai2 requested a review from ekneg54 August 23, 2023 12:52
@dtrai2 dtrai2 self-assigned this Aug 23, 2023
@dtrai2 dtrai2 linked an issue Aug 23, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (11f1442) 92.28% compared to head (6cada15) 92.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   92.28%   92.38%   +0.09%     
==========================================
  Files         133      133              
  Lines        9595     9597       +2     
==========================================
+ Hits         8855     8866      +11     
+ Misses        740      731       -9     
Files Changed Coverage Δ
logprep/util/time_measurement.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrai2 dtrai2 marked this pull request as ready for review August 28, 2023 06:17
@ekneg54 ekneg54 merged commit ed54b25 into main Aug 28, 2023
10 checks passed
@ppcad ppcad mentioned this pull request Sep 1, 2023
@ekneg54 ekneg54 deleted the 434-deleter-doesnt-delete-logs branch February 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleter doesn't delete logs
3 participants