-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove logaggregator #439
remove logaggregator #439
Conversation
Thank you for finding this! I need to check if aggregation is still needed. |
Log aggregation is still needed, so please don't remove it. |
The other way to fix it is to only log generic lines to avoid that the dict is getting bigger and bigger. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 92.32% 92.36% +0.04%
==========================================
Files 137 135 -2
Lines 9628 9539 -89
==========================================
- Hits 8889 8811 -78
+ Misses 739 728 -11
☔ View full report in Codecov by Sentry. |
ah, can you also please add a CHANGELOG.md entry. |
Co-authored-by: dtrai2 <[email protected]>
In our work we noticed a big memory leak during debug mode. this should resolve it.
@ppcad please confirm, that you do not need the log aggregation, because we do not need it either.