add retry mechanism to write_backlog #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekneg54
requested changes
Jun 12, 2024
Comment on lines
146
to
161
| def _parallel_bulk_with_retries(self, client, actions, *args, **kwargs): | ||
| bulk_delays = 1 | ||
| for _ in range(self._config.bulk_retries): | ||
| try: | ||
| self._parallel_bulk(actions, client, *args, **kwargs) | ||
| return | ||
| except search.ConnectionError as error: | ||
| raise error | ||
| except search.exceptions.TransportError as error: | ||
| if self._message_exceeds_max_size_error(error): | ||
| raise error | ||
| time.sleep(bulk_delays) | ||
| bulk_delays += random.randint(500, 1000) / 1000 | ||
| raise FatalOutputError( | ||
| self, "Opensearch too many requests, all parallel bulk retries failed" | ||
| ) |
There was a problem hiding this comment.
instead of writing this new method, how about extending the called method and add the max_retries parameter to the signature and use it?
There was a problem hiding this comment.
well I implemented it as a second method to reduce nesting. I reverted it now, please have a look at it and let me know which version you like more: (a) all in one method or (b) split up into two methods.
Co-authored-by: Jörg Zimmermann <[email protected]>
ekneg54
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.