Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration overwrites with default values #613

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Jun 20, 2024

closes #611

@ekneg54 ekneg54 added the bug Something isn't working label Jun 20, 2024
@ekneg54 ekneg54 self-assigned this Jun 20, 2024
@ekneg54 ekneg54 linked an issue Jun 20, 2024 that may be closed by this pull request
@ekneg54 ekneg54 force-pushed the 611-configuration-overwrites-with-default-values branch from 28e1822 to fc9d946 Compare June 20, 2024 12:46
instead of using the last falsy value which asumes, that
all attributes have a falsy default we return the last non
default value instead.
@ekneg54 ekneg54 requested a review from dtrai2 June 20, 2024 14:19
@ekneg54 ekneg54 marked this pull request as ready for review June 20, 2024 14:19
@ekneg54 ekneg54 merged commit e8fcf3a into main Jun 21, 2024
12 checks passed
@ekneg54 ekneg54 deleted the 611-configuration-overwrites-with-default-values branch June 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration overwrites with default values
2 participants