Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add readiness checks #652

Merged
merged 52 commits into from
Sep 19, 2024
Merged

add readiness checks #652

merged 52 commits into from
Sep 19, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Aug 21, 2024 •
edited
Loading

todo

  • provide healthcheck http endpoint
  • document healthchecks
  • update chart templates to use healthchecks by default
  • update chart version
  • update changelog
  • add tests for charts
  • add tests for endpoint
  • add tests for component health checks
  • fix restart of prometheus endpoint if pipeline restarts

healthcheck cases:

  • logprep is not healthy if output or input can't be reached
  • logprep is not healthy if error occurs during get_next or store
  • logprep is healthy after it was unhealthy if no error occurs during get_next or store
  • logprep is not healthy if http_input can't serve requests (queue full)

mechanic is implemented for at minimum

  • http_input
  • confluentkafka_input
  • confluentkafka_output
  • opensearch_output

@ekneg54 ekneg54 added the enhancement New feature or request label Aug 21, 2024
@ekneg54 ekneg54 self-assigned this Aug 21, 2024
@ekneg54 ekneg54 force-pushed the dev-add-readiness-check-probe branch from c6a37d9 to 1f390a8 Compare August 29, 2024 16:31
@ekneg54 ekneg54 force-pushed the dev-add-readiness-check-probe branch 4 times, most recently from 8d3a83f to 412d93d Compare September 13, 2024 14:48
@ekneg54 ekneg54 marked this pull request as ready for review September 13, 2024 17:59
@ekneg54 ekneg54 requested a review from djkhl September 13, 2024 18:07
@ekneg54
fix tests for injecting health functions
5263b24
@ekneg54
revise inject behavior
ff876d7
@ekneg54
implement restart behavior
0963479
@ekneg54
Refactor PrometheusExporter test to use uvicorn_config for server host
d45f5c7
@ekneg54
Refactor ThreadingHTTPServer shut_down method to handle case when ser…
75f7478 
…ver is None
@ekneg54
Remove setup method in ConfluentKafkaInput and ConfluentKafkaOutput
61eadd1
@ekneg54
Remove wait for health from setup method in Component class
e95b920
@ekneg54
Refactor ThreadingHTTPServer shut_down method to ensure graceful serv…
1ba9f1a 
…er exit
@ekneg54
implement update_healthchecks to prometheus_exporter
c8cceb0
@ekneg54
fix pipeline_manager tests
8b20a5e
@ekneg54
fix pipeline_manager call order
cece1a3
@ekneg54
fix thread does not terminate sometimes
32ab246
@ekneg54
fix kafka tests
9c69e39
@ekneg54
add comment for component setup method
a181ea5
@ekneg54
add development example setup
ec78e39
@ekneg54
move configuration to the top level of documentation
8937904
@ekneg54
add healthcheck documentation
99165fd
@ekneg54
update changelog
36c98e4
@ekneg54
rewrite documentation intro
8e7a0e8
@ekneg54
rewrite documentation intro
6c41bd1
@ekneg54
fix amides test
db128f5
@ekneg54 ekneg54 force-pushed the dev-add-readiness-check-probe branch from 6fc4a6a to db128f5 Compare September 16, 2024 09:36
djkhl
djkhl requested changes Sep 19, 2024
View reviewed changes
logprep/connector/http/input.py Outdated Show resolved Hide resolved
logprep/connector/opensearch/output.py Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/user_manual/execution.rst Outdated Show resolved Hide resolved
@ekneg54 ekneg54 force-pushed the dev-add-readiness-check-probe branch from 951ca75 to db128f5 Compare September 19, 2024 13:03
@ekneg54 ekneg54 requested a review from djkhl September 19, 2024 13:13
djkhl
djkhl approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@djkhl djkhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding this feature! :)

@ekneg54
Copy link
Collaborator Author

ekneg54 commented Sep 19, 2024

tests are failing, but this seems to be a runner issue. merged anyway

@ekneg54 ekneg54 merged commit 34809cf into main Sep 19, 2024
9 of 13 checks passed
@ekneg54 ekneg54 deleted the dev-add-readiness-check-probe branch September 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djkhl djkhl djkhl approved these changes

Assignees

@ekneg54 ekneg54

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekneg54 @djkhl