Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release pipeline broken for arm images #670

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix release pipeline broken for arm images #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e75f93a
remove build of aarch64 cause it blocks release pipeline
ekneg54 Sep 19, 2024
97641ce
update changelog
ekneg54 Sep 19, 2024
c3887f8
skip broken ci runner test
ekneg54 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-latest-dev-release-to-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run: python -m pip install cibuildwheel

- name: Build wheels
run: python -m cibuildwheel --output-dir wheelhouse --archs x86_64,aarch64
run: python -m cibuildwheel --output-dir wheelhouse --archs x86_64

- name: Build binary wheel and a source tarball
run: pipx run build --sdist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-release-to-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
run: python -m pip install cibuildwheel

- name: Build wheels
run: python -m cibuildwheel --output-dir wheelhouse --archs x86_64,aarch64
run: python -m cibuildwheel --output-dir wheelhouse --archs x86_64

- name: Build binary wheel and a source tarball
run: pipx run build --sdist
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

* remove AutoRuleCorpusTester
* adds support for rust extension development
* adds prebuild wheels for architectures `x86_64` and `aarch64` on `manylinux` and `musllinux` based linux platforms to releases
* adds prebuild wheels for architectures `x86_64` on `manylinux` and `musllinux` based linux platforms to releases
* add manual how to use local images with minikube example setup to documentation
* move `Configuration` to top level of documentation

Expand Down
4 changes: 4 additions & 0 deletions tests/unit/util/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# pylint: disable=protected-access
# pylint: disable=line-too-long
import json
import os
import uuid
from logging import getLogger
from pathlib import Path
Expand All @@ -28,6 +29,8 @@
path_to_only_output_config,
)

in_ci = os.environ.get("GITHUB_ACTIONS") == "true"

logger = getLogger()


Expand Down Expand Up @@ -1215,6 +1218,7 @@ def test_verify_credentials_file_raises_for_unexpected_key(self, config_path, tm
):
_ = Configuration.from_sources([str(config_path)])

@pytest.mark.skipif(in_ci, reason="breaks on broken ci runner")
def test_no_config_parameter_is_overwritten_with_a_default(self, tmp_path):
prometheus_multiproc_dir: Path = tmp_path / "prometheus_multiproc_dir"
prometheus_multiproc_dir.mkdir()
Expand Down
Loading