Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporter restart #677

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Fix exporter restart #677

merged 7 commits into from
Oct 2, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Sep 28, 2024

This fixes an error from previous health check implementation causing the exporter restarting on first start of logprep.

it was extracted from #668 to reduce amount of changes

@ekneg54 ekneg54 force-pushed the fix-exporter-restart-at-setup branch from 6784019 to 718a353 Compare September 28, 2024 10:00
@ekneg54 ekneg54 marked this pull request as ready for review September 28, 2024 10:40
@ekneg54 ekneg54 requested a review from ppcad September 28, 2024 10:41
@ekneg54 ekneg54 self-assigned this Sep 28, 2024
@ekneg54 ekneg54 added the bug Something isn't working label Sep 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.29%. Comparing base (eca9240) to head (4be3e2d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
logprep/run_logprep.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   94.27%   94.29%   +0.02%     
==========================================
  Files         146      146              
  Lines        9777     9920     +143     
==========================================
+ Hits         9217     9354     +137     
- Misses        560      566       +6     
Flag Coverage Δ
94.29% <96.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ppcad ppcad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ekneg54 ekneg54 merged commit b0d8752 into main Oct 2, 2024
13 checks passed
@ekneg54 ekneg54 deleted the fix-exporter-restart-at-setup branch October 2, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants