Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix store_offsets call when last_valid_record is None #693

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix store_offsets call when last_valid_record is None #693

merged 2 commits into from
Nov 5, 2024

Conversation

dtrai2
Copy link
Collaborator

@dtrai2 dtrai2 commented Oct 31, 2024

  • Prevent store_offsets from being called before the first message is pulled.
  • Add unit test to ensure store_offsets is not called incorrectly.

@dtrai2
fix store_offsets call when last_valid_record is None
a4f1827 
- Prevent store_offsets from being called before the first message is pulled.
- Add unit test to ensure store_offsets is not called incorrectly.
@dtrai2 dtrai2 requested a review from djkhl October 31, 2024 14:11
@dtrai2 dtrai2 self-assigned this Oct 31, 2024
@dtrai2
fix typo in variable name in test_confluent_kafka_input.py
0570dc4 
- corrected variable name from `_last_valid_records` to `_last_valid_record`
@dtrai2 dtrai2 marked this pull request as ready for review November 5, 2024 10:03
@dtrai2 dtrai2 merged commit 8bbb38e into main Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djkhl djkhl djkhl approved these changes

Assignees

@dtrai2 dtrai2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtrai2 @djkhl