Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of new JK firmware (32 cells) #267

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

Confushion
Copy link
Contributor

Change detection of new JK firmware (32 cells).

Checking buf[189] is wrong: ,this is the most significant byte of field "Cycle Capacity" and this field will slowly increase in value.

Now we check the least significant byte of field "Nominal Capacity", which is a static field.
This field has value 0 in other fw version.

Fixes issues #209 , #235 , #265

@fl4p fl4p merged commit 4f38588 into fl4p:master Dec 28, 2024
@fl4p
Copy link
Owner

fl4p commented Dec 28, 2024

thanks

@leolionart
Copy link

leolionart commented Dec 28, 2024

Now the problem is to wrong the battery percentage up to more than 160000%. I had to go back to the previous version to fix this bug

@jariojose
Copy link

This change generated many marking errors here in my BMS. Most of them display only null values (zeros).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants