Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsahiShimbun #682

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Add AsahiShimbun #682

merged 4 commits into from
Jan 16, 2025

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jan 13, 2025

No description provided.

@MaxDall MaxDall requested a review from addie9800 January 13, 2025 17:14
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the next Japanese publisher 👍

src/fundus/publishers/jp/asahi_shimbun.py Outdated Show resolved Hide resolved
src/fundus/publishers/jp/asahi_shimbun.py Show resolved Hide resolved
src/fundus/publishers/jp/asahi_shimbun.py Outdated Show resolved Hide resolved
@MaxDall MaxDall requested a review from addie9800 January 14, 2025 14:38
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MaxDall MaxDall merged commit 0853045 into master Jan 16, 2025
5 checks passed
@MaxDall MaxDall deleted the add-asahi-shimbun branch January 16, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants