fix: Ray should not be able to escape CircleHitbox
#3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
erickzanardo,
luanpotter,
renancaraujo,
wolfenrain and
ufrshubham
erickzanardo
approved these changes
Oct 13, 2024
luanpotter
reviewed
Oct 13, 2024
| // of the circle and then directly intersecting and causing the reflecting | ||
| // ray to go in the wrong direction. | ||
| _temporaryOrigin.setValues( | ||
| ray.origin.x + ray.direction.x * 0.00001, |
There was a problem hiding this comment.
should we put that into an epsilon?
luanpotter
approved these changes
Oct 13, 2024
wolfenrain
approved these changes
Oct 14, 2024
It can happen, but it's very unlikely since the epsilon is so small. So the problem was that it properly calculates the first ray, but then it's calculating what the reflection ray will intersect and since its origin is straight on the edge of the circle sometimes the origin point was counted as the intersection, so we add a small vector to origin with the same direction as the ray to "get out" of the origin. |
luanpotter
pushed a commit
that referenced
this pull request
Oct 15, 2024
A raycasted ray should not be able to escape a `CircleHitbox` if it originates from inside of it (or on the edge and has a direction inwards). Fixes: #3333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A raycasted ray should not be able to escape a
CircleHitboxif it originates from inside of it (or on the edge and has a direction inwards).Fixes: #3333
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues