fix: Widgets flickering #3343
Merged
fix: Widgets flickering #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Oct 14, 2024
Comment on lines
99
to
100
| return frame.sprite.image != newFrame.sprite.image || | ||
| frame.sprite.src != newFrame.sprite.src; |
There was a problem hiding this comment.
You need to take previous into consideration here right? And then have the default of the fold true instead of false.
There was a problem hiding this comment.
Duh 🤦 ofc I need! Thanks!
wsv-accidis
reviewed
Oct 14, 2024
| @@ -21,6 +22,15 @@ void addWidgetsStories(Dashbook dashbook) { | |||
| out the settings on the pen icon. | |||
| ''', | |||
| ) | |||
| ..add( | |||
There was a problem hiding this comment.
Love that you're adding an extra example for this as well!
|
Thank you for the swift action on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the flickering in the widgets:
SpriteAnimationWidget,SpriteWidgetandNineTileBoxWidget.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #3342