Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Widgets flickering #3343

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix: Widgets flickering #3343

merged 3 commits into from
Oct 16, 2024

Conversation

erickzanardo
Copy link
Member

Description

Fix the flickering in the widgets: SpriteAnimationWidget, SpriteWidget and NineTileBoxWidget.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #3342

@erickzanardo erickzanardo requested a review from a team October 14, 2024 11:59
@erickzanardo erickzanardo marked this pull request as draft October 14, 2024 11:59
Comment on lines 99 to 100
return frame.sprite.image != newFrame.sprite.image ||
frame.sprite.src != newFrame.sprite.src;
Copy link
Member

@spydon spydon Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to take previous into consideration here right? And then have the default of the fold true instead of false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh 🤦 ofc I need! Thanks!

@@ -21,6 +22,15 @@ void addWidgetsStories(Dashbook dashbook) {
out the settings on the pen icon.
''',
)
..add(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that you're adding an extra example for this as well!

@erickzanardo erickzanardo marked this pull request as ready for review October 16, 2024 15:03
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, lgtm!

@wsv-accidis
Copy link

Thank you for the swift action on this!

@erickzanardo erickzanardo merged commit ff170dc into main Oct 16, 2024
8 checks passed
@erickzanardo erickzanardo deleted the fix/widgets-flickering branch October 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NineTileBoxWidget flickers inside of AnimatedOpacity container
3 participants