Fix for issue #1413 (cherry-pick #179 to release_18x) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanpkc
changed the title
bryanpkc
reviewed
Jul 29, 2024
bryanpkc
reviewed
Jul 29, 2024
| @@ -36,7 +36,8 @@ enum class VectorLibrary { | |||
| }; | |||
|
|
|||
| TargetLibraryInfoImpl *createTLII(llvm::Triple &TargetTriple, | |||
| VectorLibrary Veclib); | |||
| VectorLibrary Veclib, | |||
| bool targetAVX512); | |||
There was a problem hiding this comment.
Please use spaces instead of tabs for indenting your code. Try running git clang-format on your diff.
There was a problem hiding this comment.
This code was generated by clang-format only. let me recheck again.
bryanpkc
reviewed
Jul 29, 2024
bryanpkc
reviewed
Jul 29, 2024
bryanpkc
changed the title
bryanpkc
changed the title
shivaramaarao
force-pushed
the
pgmath_avx512_fix2
branch
from
0d86b1c
to
e51235f
Compare
bryanpkc
reviewed
Aug 11, 2024
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
shivaramaarao
force-pushed
the
pgmath_avx512_fix2
branch
from
e51235f
to
9bfd70d
Compare
bryanpkc
approved these changes
Aug 12, 2024
pawosm-arm
approved these changes
Aug 12, 2024
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 19, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 19, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 25, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 26, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Oct 2, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
that referenced
this pull request
Oct 14, 2024
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified. This fix is cherry-picked from PR #179 for the release_17x branch.