Merge branch 'andrius/fdc-rewarding-fixes' into 'main'

FDC rewarding bugfixes See merge request flarenetwork/ftso/ftso-scaling!150
flare-foundation · Feb 6, 2025 · 1e45599 · 1e45599
2 parents 3432ee3 + aa5d98f
commit 1e45599
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/apps/ftso-reward-calculation-process/src/libs/attestation-type-appearances.ts b/apps/ftso-reward-calculation-process/src/libs/attestation-type-appearances.ts
@@ -22,7 +22,7 @@ export function calculateAttestationTypeAppearances(rewardEpochId: number): void
    const attestationTypeCount = new Map<string, number>();
    for (
       let votingRoundId = rewardEpochInfo.signingPolicy.startVotingRoundId;
-      votingRoundId < rewardEpochInfo.endVotingRoundId;
+      votingRoundId <= rewardEpochInfo.endVotingRoundId;
       votingRoundId++
    ) {
       const currentCalculationData = deserializeDataForRewardCalculation(

diff --git a/libs/fsp-rewards/src/DataManagerForRewarding.ts b/libs/fsp-rewards/src/DataManagerForRewarding.ts
@@ -238,7 +238,7 @@ export class DataManagerForRewarding extends DataManager {
     providedMessageHash: MessageHash | undefined = undefined,
     logger: ILogger
   ): Map<MessageHash, GenericSubmissionData<ISignaturePayload>[]> {
-    const signatureMap = new Map<MessageHash, Map<Address, GenericSubmissionData<ISignaturePayload>>>();
+    const signatureMap = new Map<MessageHash, GenericSubmissionData<ISignaturePayload>[]>();
     for (const submission of submissions) {
       for (const message of submission.messages) {
         try {
@@ -300,14 +300,13 @@ export class DataManagerForRewarding extends DataManager {
                 `Critical error: signerToSigningWeight or signerToDelegationAddress is not defined for signer ${signer}`
               );
             }
-            const signatures =
-              signatureMap.get(messageHash) || new Map<Address, GenericSubmissionData<ISignaturePayload>>();
+            const signatures = signatureMap.get(messageHash) || [];
             const submissionData: GenericSubmissionData<ISignaturePayload> = {
               ...submission,
               messages: signaturePayload,
             };
             signatureMap.set(messageHash, signatures);
-            signatures.set(signer, submissionData);
+            signatures.push(submissionData);
           }
         } catch (e) {
           console.log(e)

diff --git a/libs/fsp-rewards/src/reward-calculation/fdc/fdc-utils.ts b/libs/fsp-rewards/src/reward-calculation/fdc/fdc-utils.ts
@@ -20,7 +20,7 @@ export function uniqueRequestsIndices(attestationRequests: AttestationRequest[])
    const result: number[][] = [];
    for (let i = 0; i < attestationRequests.length; i++) {
       const request = attestationRequests[i];
-      if (!encountered.get(request.data)) {
+      if (encountered.get(request.data) == undefined) {
          encountered.set(request.data, result.length);
          result.push([i]);
       } else {