Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate GENESIS_FORK_VERSION env flag #676

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix duplicate GENESIS_FORK_VERSION env flag #676

merged 1 commit into from
Aug 16, 2024

Conversation

bhakiyakalimuthu
Copy link
Contributor

@bhakiyakalimuthu bhakiyakalimuthu commented Aug 14, 2024 •
edited
Loading

📝 Summary

This PR resolves the issue of duplicate GENESIS_FORK_VERSION env flag.

⛱ Motivation and Context

GENESIS_FORK_VERSION environment flag was being used in two different places, leading to conflicting env values.

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@avalonche avalonche mentioned this pull request Aug 14, 2024
Closed
@metachris metachris merged commit 828a637 into flashbots:develop Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalonche avalonche avalonche approved these changes

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhakiyakalimuthu @MariusVanDerWijden @avalonche @metachris