This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
update ethers-rs to 0.6.1 #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support change to the gasFee field of Transactions due to update
this prevents a transaction with both an effectiveGasPrice and gasPrice populated from causing a panic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Older versions of ethers-rs depend on curl, which has issues compiling for M1 macs. Newer versions of ethers-rs do not require curl, so it should be updated.
Solution
Updates to ethers-rs change the type of the
gas_pricefield ofTransactionfromU256toOption<U256>, due to thegasPricefield being deprecated for EIP-1559 transactions.As a result,
gas_price_txs_from_blockhas been added to help implement proper gas price calculation for both EIP-1559 transactions and non EIP-1559 transactions. This function follows the advice included in the gasPrice deprecation PR, using effectiveGasPrice from receipts for EIP-1559 transactions, and gasPrice for non EIP-1559 transactions. This solution is meant to work post gasPrice removal for EIP-1559 transactions.This also updates
BlockNumbertoBlockId.