-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically launch with GDK_SCALE for HiDPI support #42
Conversation
Started test build 54030 |
Build 54030 successful
|
Btw, motivation for this PR originated from this post. |
cool! Thanks! Can you use a commit, in addition to the tag for xgetres? Because concept of a "tag" in git is surprisingly volatile and may change. The commit hash is less likely to change. Have you thought about making this a shared-module? It seems there is a non-trivial number of flatpaked Java apps and having the highdpi stuff put in a more central place may benefit existing and new apps. |
Ok I'm adding
I'm currently proposing features like this to be added in openjdk11 extension, see this issue, but maybe you're right and shared-module could be a good home for some of these. |
Started test build 54083 |
Build 54083 failed |
Similar to other Java apps in flathub, use the 'xgetres' binary to automatically retrieve current DPI and so launch the java command with a proper GDK_SCALE value.
Started test build 54084 |
Build 54084 failed |
yeah, I don't mind which place, but my feeling says that this is non-trivial enough to warrant some common place s.t. apps can re-use the work. |
Similar to other Java apps in flathub[1], use the
xgetres
binary to automatically retrieve current DPI of our X session
and so launch the java command with a proper GDK_SCALE value.
[1] like these:
com.github.mgropp.PdfJumbler
com.itextpdf.RUPS
net.sourceforge.pdfchain
io.sourceforge.Pixelitor
com.diy_fever.DIYLayoutCreator
org.verapdf.veraPDF