Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically launch with GDK_SCALE for HiDPI support #42

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

nbenitez
Copy link
Contributor

Similar to other Java apps in flathub[1], use the xgetres
binary to automatically retrieve current DPI of our X session
and so launch the java command with a proper GDK_SCALE value.

[1] like these:
com.github.mgropp.PdfJumbler
com.itextpdf.RUPS
net.sourceforge.pdfchain
io.sourceforge.Pixelitor
com.diy_fever.DIYLayoutCreator
org.verapdf.veraPDF

@flathubbot
Copy link
Contributor

Started test build 54030

@flathubbot
Copy link
Contributor

Build 54030 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51978/org.openstreetmap.josm.flatpakref

@nbenitez
Copy link
Contributor Author

Btw, motivation for this PR originated from this post.

@muelli
Copy link
Collaborator

muelli commented Jul 22, 2021

cool! Thanks!

Can you use a commit, in addition to the tag for xgetres? Because concept of a "tag" in git is surprisingly volatile and may change. The commit hash is less likely to change.

Have you thought about making this a shared-module? It seems there is a non-trivial number of flatpaked Java apps and having the highdpi stuff put in a more central place may benefit existing and new apps.

@nbenitez
Copy link
Contributor Author

cool! Thanks!

Can you use a commit, in addition to the tag for xgetres? Because concept of a "tag" in git is surprisingly volatile and may change. The commit hash is less likely to change.

Ok I'm adding commit (which can be added alongside tag, and both will be verified).

Have you thought about making this a shared-module? It seems there is a non-trivial number of flatpaked Java apps and having the highdpi stuff put in a more central place may benefit existing and new apps.

I'm currently proposing features like this to be added in openjdk11 extension, see this issue, but maybe you're right and shared-module could be a good home for some of these.

@flathubbot
Copy link
Contributor

Started test build 54083

@flathubbot
Copy link
Contributor

Build 54083 failed

Similar to other Java apps in flathub, use the 'xgetres'
binary to automatically retrieve current DPI and so launch
the java command with a proper GDK_SCALE value.
@flathubbot
Copy link
Contributor

Started test build 54084

@flathubbot
Copy link
Contributor

Build 54084 failed

@muelli
Copy link
Collaborator

muelli commented Jul 24, 2021

I'm currently proposing features like this to be added in openjdk11 extension, see this issue, but maybe you're right and shared-module could be a good home for some of these.

yeah, I don't mind which place, but my feeling says that this is non-trivial enough to warrant some common place s.t. apps can re-use the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants