Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize application as app #1327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rffontenelle
Copy link
Contributor

Uniformize occurrences of "application"(s) and "app"(s) as the latter.

Occurrences of application(s):

  • src/background.c, line 754
    The ‘run in background’ permission can be changed at any time from the application settings.

  • src/location.c, line 566
    An application wants to use your location.

  • src/screenshot.c, line 265
    Allow Applications to Take Screenshots?

  • src/screenshot.c, line 266
    An application wants to be able to take screenshots at any time.

  • src/wallpaper.c, lines 215 and 216
    Allow Applications to Set Backgrounds?
    An application is requesting to be able to change the background image.

Occurrences of app(s):

  • src/device.c, line 122 and 123, 137 and 138
    Allow app to Use the Microphone?
    An app wants to access recording devices.
    Allow app to Use the Speakers?
    An app wants to access audio devices.

  • src/device.c, lines 152 and 153
    Allow app to Use the Camera?
    An app wants to access camera devices.

  • src/dynamic-launcher.c, lines 131 and 719
    Desktop file id missing app id prefix '%s.': %s
    RequestInstallToken() not allowed for app id %s

@snwh
Copy link

snwh commented Apr 10, 2024

Was asked to ack, LGTM 👍

@@ -751,7 +751,7 @@ handle_request_background_in_thread_func (GTask *task,
subtitle = g_strdup_printf (_("%s requests to be started automatically and run in the background."), info ? g_app_info_get_display_name (info) : id);
else
subtitle = g_strdup_printf (_("%s requests to run in the background."), info ? g_app_info_get_display_name (info) : id);
body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the application settings."));
body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the app settings."));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this referring to the settings for the app, or to Applications settings found in Settings apps?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application settings found in Settings app. But what about other DEs on this and "app" name?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the case, then it would be good to have this be "applications settings" since it would be referring to general settings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worse than what is it right now? Should we just go ahead and merge this?

At the end of the day, this is generic code shared by all environments so being more specific seems out of the question.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "application settings" is still confusing in my opinion. However, that’s less a problem if all DEs give the background permission automatically like in GNOME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

4 participants