Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenCast/RemoteDesktop: add option to pass a description #939

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grulja
Copy link
Contributor

@grulja grulja commented Jan 2, 2023

Description can be used to further specify details about the request itself. This can be for example used by web browsers to specify the web page that requests the access or hinting a scene/source in case of applications like OBS Studio.

Fixes #758

Description can be used to further specify details about the request itself.
This can be for example used by web browsers to specify the web page that
requests the access or hinting a scene/source in case of applications like
OBS Studio.
dialogs allowing users to make more well informed decisions.
An example of such description can be a name of a web page
making request to use the shared resources.
E.g. www.videomeeting.com is requesting access to your screen.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think expanding how the string should look, e.g. how to punctuate, how long, etc, and in what context it will be displayed. This is to avoid having one app have

www.videomeeting is requesting access to your screen

while another is

www.videomeeting.com wants to access your screen.

Please select the monitor you want to share and press Submit

Might be good to make it a(ss) so that we can have "plaintext" and potentially add formatable options in the future (e.g. to add emphasis on the domain) in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allanday can you please help us here? You might know better how to tell consumers how the string should actually look like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allanday friendly ping.

@grulja grulja requested a review from allanday February 22, 2023 08:46
@GeorgesStavracas GeorgesStavracas added new api This requires adding API to an existing portal needs discussion Needs discussion on how to implement or fix the corresponding task portal: screencast Screencast portal labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Needs discussion on how to implement or fix the corresponding task new api This requires adding API to an existing portal portal: screencast Screencast portal
Projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

Accept a help/hint string for screencasting/remote desktop portal
3 participants