parametrize the thread test with daemon

flojoy-ai · Aug 2, 2023 · 76af006 · 76af006
1 parent d419d62
commit 76af006
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/tests/flojoy_node_venv_test_.py b/tests/flojoy_node_venv_test_.py
@@ -126,7 +126,8 @@ def empty_function_with_error():
         empty_function_with_error()
 
 
-def test_run_in_venv_runs_within_thread(mock_venv_cache_dir):
+@pytest.mark.parametrize("daemon", [True, False])
+def test_run_in_venv_runs_within_thread(mock_venv_cache_dir, daemon):
 
     from threading import Thread
     from queue import Queue
@@ -148,7 +149,7 @@ def func_with_venv():
 
     # Run the function in a thread
     queue = Queue()
-    thread = Thread(target=function_to_run_within_thread, args=(queue,))
+    thread = Thread(target=function_to_run_within_thread, args=(queue,), daemon=daemon)
     thread.start()
     thread.join()
     # Check that the thread has finished