Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

added boolean DC type #101

Merged
merged 4 commits into from
Oct 3, 2023
Merged

added boolean DC type #101

merged 4 commits into from
Oct 3, 2023

Conversation

youngsun4786
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Sep 10, 2023

PYT-12 Add Boolean DC type

This issue is related to NOD-56 where it should have the DC type of boolean that can be used for nodes in the future.

@youngsun4786 youngsun4786 marked this pull request as ready for review September 11, 2023 16:58
itsjoeoui
itsjoeoui previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@itsjoeoui itsjoeoui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly_utils.py needs update as well as write_to_memory in small_memory.py

@itsjoeoui itsjoeoui self-requested a review September 11, 2023 18:53
itsjoeoui
itsjoeoui suggested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@itsjoeoui itsjoeoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly_utils.py needs update to consider boolean type as well as write_to_memory in small_memory.py

@youngsun4786 youngsun4786 self-assigned this Oct 2, 2023
@itsjoeoui itsjoeoui merged commit 1f5a25d into develop Oct 3, 2023
@itsjoeoui itsjoeoui deleted the nick/pyt-12-add-boolean-dc-type branch October 3, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@39bytes 39bytes 39bytes approved these changes

@itsjoeoui itsjoeoui itsjoeoui approved these changes

@dstrande dstrande Awaiting requested review from dstrande

Assignees

@youngsun4786 youngsun4786

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngsun4786 @itsjoeoui @39bytes