This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix exception handling for run_in_venv
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smahmed776 Improved exception handling and logging, PTAL |
Roulbac
commented
Aug 2, 2023
Roulbac
commented
Aug 14, 2023
Signed-off-by: Joey Yu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the function would return and attempt to pickle the resulting (broken) object before the child process is able to finish handling an exception it raised. This results in an error and the pipe blocks.
This PR fixes the issue by enclosing the whole process of deserialisation-execution-serialization into the try/catch.