This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Stream logs from run_in_venv to the logging module at the pip install step
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce
LogPipewhich allows logging from the created subprocess by_install_pip_dependenciesinto the main parent process.Sometime a pip install step can take a while, and it is important to stream logs back in real time so that the user can know what's happening.
LogPipewas tested on both Mac and Windows. Additionally, thetest-flojoy-node-envgithub action was made verbose to check that the logs are streamed there as well for Mac/Windows/Ubuntu.cc @jackparmer @itsjoeoui