Fix python compatibility #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thank you for the issue and PR. I'm ok to merge the PR as it removes the need of tensorflow-gpu, however it does not resolve the issue #4 (as python>=3.8 requires tf>1.15 making the last assertion of |
|
It was: I don't know how to make TeachMyAgent compatible with python 3.8. But at least with this PR there is no risk to encounter incompatibility late. |
|
The PR is therefore very badly named, it should rather be: "Compatibility check at installation". |
|
Alright, no problem ! I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The problem associated with this RP is presented on issue #4 .
Instead of having
tensorflow-gpuin the requirements, I suggest you to do like in theopenai/baselinesrepo : just check that TensorFlow is installed. This allows people like me who don't have a gpu to be able to install the package anyway, without having to manually replacetensorflow-gpuwithtensorflowinsetup.py.Regards.