Seems to fix to the hide non-existing issue #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@corentinlger This PR seems to fix to the hide non-existing issue #120 . In case you have time to have a quick look at it, can you tell me if you think it makes sense? (or more importantly, if you think it won't break anything else). Thanks :)
See "How to test" below.
Related Issue (if applicable)
#120
How to Test
controller.run()
controller.run()
Before this fix, we were having a
RuntimeError: _pending_writes should be non-None when we have a document lock, and we should have the lock when the document changes' in the last executed notebook cell
. It shouldn't be the case now.Also check that we don't see hidden entities in the interface (if it works, you should see 7 resources).