Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add cfl-static as a TARGETS #206

Merged

Conversation

cosmo0920
Copy link
Contributor

This is because system installation with deb/rpm packages should include libcfl-static.a for correct linking for cmetrics library.

Otherwise, when system OK is displayed in configuration phase, libcfl-static.a linking should be failed.

This is because system installation with deb/rpm packages should include
libcfl-static.a for correct linking for cmetrics library.

Signed-off-by: Hiroshi Hatake <[email protected]>
@edsiper
Copy link
Member

edsiper commented Jul 25, 2024

why packaging systems needs the static library ?, cfl should be bundled by default inside the main cmetrics library

@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jul 25, 2024

When installing cmetrics library as a package, libcfl-static.a is also needed to bundle cmetrics.deb or cmetrics.rpm.
fluent-otel-proto, mpack and xxhash are also installed as libraries when packaging:
https://github.com/fluent/cmetrics/blob/master/CMakeLists.txt#L277
https://github.com/fluent/cmetrics/blob/master/CMakeLists.txt#L218
https://github.com/fluent/cmetrics/blob/master/CMakeLists.txt#L254

In addition, this library targets are only installed when enabling CMT_INSTALL_TARGETS option is turned on.

Just developing fluent-bit and its related software in C, this issue shouldn't encounter.
But, when developing calyptia-plugin or cmetrics-go, we need to install cmetrics as a DEB or RPM package to load cmetrics functionalities.

@edsiper
Copy link
Member

edsiper commented Aug 5, 2024

thanks for the explanation, so if CMT_INSTALL_TARGETS is needed all good

@edsiper edsiper merged commit cfc8af5 into master Aug 5, 2024
18 checks passed
@edsiper edsiper deleted the cosmo0920-add-cfl-static-targets-for-deb-installation branch August 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants