input_chunk: express specific errors using negative encoded numerical error values. #9919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change some internal
flb_input_chunk
APIs to return a negative value encoding specificerrno
codes in them instead of just return-1
.The semantics of the calls should not change but it does force callers of the relevant functions to check for negative values instead of
-1
.This PR also has a fix for
in_emitter
to accept negative values as errors instead of just the value-1
.Description
This PR includes everal changes to the
flb_input_chunk
API so it is possible to know the nature of the error when a call toflb_log_append
fails.There is a refactor of the function
input_chunk_get
to return a negative value encoded with anerrno
number to specify the following possible errors:The function
input_chunk_append_raw
has been refactored to return the negative value oferrno
if it is set during the call if there is an error or the negative value ofEIO
if not.These changes are necessary for a forth-coming change in
in_http
which uses these errors and others to generate more verbose HTTP error response codes.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.