fix: run integration tests with-all-dependencies (#216)

.github/workflows/integration.yml

@@ -40,7 +40,7 @@ jobs:
         run: |
           cd tests/integration
           composer remove phpunit/phpunit --dev
-          composer require pestphp/pest:^2.0 pestphp/pest-plugin-laravel:^2.0 pestphp/pest-plugin-drift:^2.0 --dev
+          composer require pestphp/pest:^2.0 pestphp/pest-plugin-laravel:^2.0 pestphp/pest-plugin-drift:^2.0 --dev -W
           vendor/bin/pest --init
           vendor/bin/pest --drift
           composer require livewire/livewire:^${{ matrix.livewire }}

phpstan.neon.dist

@@ -9,7 +9,6 @@ parameters:
     level: 5 # The level 9 is the highest level
     ignoreErrors: []
     excludePaths: []
-    checkMissingIterableValueType: false
     scanFiles:
       - vendor/chinleung/laravel-locales/src/helpers.php
     scanDirectories:

src/Models/Invitation.php

@@ -20,11 +20,6 @@ class Invitation extends Model
 {
     use HasFactory;
 
-    /**
-     * The attributes that are mass assignable.
-     *
-     * @var array<string>
-     */
     protected $fillable = [
         'email',
         'role',

stubs/app/Http/Controllers/JoinController.php

@@ -2,6 +2,7 @@
 
 namespace App\Http\Controllers;
 
+use App\Models\Organization;
 use App\Models\User;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
@@ -15,15 +16,16 @@ class JoinController extends Controller
      */
     public function cancel(Request $request): RedirectResponse
     {
+        /** @var Organization */
         $joinable = $request->user()->joinable;
 
+        flash(__('You have cancelled your request to join :team.', ['team' => $joinable->getTranslation('name', 'en')]), 'success');
+
         $request->user()->forceFill([
             'joinable_type' => null,
             'joinable_id' => null,
         ])->save();
 
-        flash(__('You have cancelled your request to join :team.', ['team' => $joinable->name]), 'success');
-
         return redirect(\localized_route($joinable->getRoutePrefix().'.show', $joinable));
     }
 
@@ -32,6 +34,7 @@ public function cancel(Request $request): RedirectResponse
      */
     public function approve(Request $request, User $user): RedirectResponse
     {
+        /** @var Organization */
         $joinable = $user->joinable;
 
         Gate::forUser($request->user())->authorize('update', $joinable);
@@ -53,6 +56,7 @@ public function approve(Request $request, User $user): RedirectResponse
      */
     public function deny(Request $request, User $user): RedirectResponse
     {
+        /** @var Organization */
         $joinable = $user->joinable;
 
         Gate::forUser($request->user())->authorize('update', $joinable);

stubs/app/Models/Organization.php

@@ -24,31 +24,16 @@ class Organization extends Model
     use HasTranslations;
     use Notifiable;
 
-    /**
-     * The attributes that are mass assignable.
-     *
-     * @var array<string>
-     */
     protected $fillable = [
         'name',
         'locality',
         'region',
     ];
 
-    /**
-     * The relationships that should be deleted when an organization is deleted.
-     *
-     * @var array
-     */
     protected mixed $cascadeDeletes = [
         'users',
     ];
 
-    /**
-     * The attributes that are translatable.
-     *
-     * @var array<string>
-     */
     public array $translatable = [
         'name',
         'slug',

stubs/app/Models/Resource.php

@@ -15,22 +15,12 @@ class Resource extends Model
     use HasTranslatableSlug;
     use HasTranslations;
 
-    /**
-     * The attributes that are mass assignable.
-     *
-     * @var array<string>
-     */
     protected $fillable = [
         'title',
         'user_id',
         'summary',
     ];
 
-    /**
-     * The attributes that are translatable.
-     *
-     * @var array<string>
-     */
     public mixed $translatable = [
         'title',
         'slug',

stubs/app/Models/ResourceCollection.php

@@ -16,20 +16,12 @@ class ResourceCollection extends Model
     use HasTranslatableSlug;
     use HasTranslations;
 
-    /**
-     * The attributes that are mass assignable.
-     *
-     * @var array<string>
-     */
     protected $fillable = [
         'title',
         'user_id',
         'description',
     ];
 
-    /**
-     * The attributes that are transterms
-     */
     public array $translatable = [
         'title',
         'slug',

stubs/app/Models/User.php

@@ -24,44 +24,24 @@ class User extends Authenticatable implements HasLocalePreference, MustVerifyEma
     use Notifiable;
     use TwoFactorAuthenticatable;
 
-    /**
-     * The attributes that are mass assignable.
-     *
-     * @var array<string>
-     */
     protected $fillable = [
         'name',
         'email',
         'password',
         'locale',
     ];
 
-    /**
-     * The attributes that should be hidden for arrays.
-     *
-     * @var array<int, string>
-     */
     protected $hidden = [
         'password',
         'remember_token',
         'two_factor_recovery_codes',
         'two_factor_secret',
     ];
 
-    /**
-     * The attributes that should be cast to native types.
-     *
-     * @var array<string, string>
-     */
     protected $casts = [
         'email_verified_at' => 'datetime',
     ];
 
-    /**
-     * The relationships that should be deleted when a user is deleted.
-     *
-     * @var array
-     */
     protected mixed $cascadeDeletes = [
         'organizations',
     ];
@@ -123,7 +103,10 @@ public function joinable(): MorphTo
      */
     public function hasRequestedToJoin(mixed $model)
     {
-        return $this->joinable && $this->joinable->id === $model->id;
+        /** @var Organization|null */
+        $joinable = $this->joinable;
+
+        return ! is_null($joinable) && $joinable->id === $model->id;
     }
 
     /**

stubs/phpstan.neon.dist

@@ -20,4 +20,3 @@ parameters:
       - vendor/chinleung/laravel-locales/src/helpers.php
 
     ignoreErrors: []
-    checkMissingIterableValueType: false