Initial implementation #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
macno
commented
Mar 11, 2024
•
macno
commented
- add CI
- lint/test/build
- coverage
- release image
macno
force-pushed
the
first-release
branch
4 times, most recently
from
f835cea to
4d28ebd
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
macno
force-pushed
the
first-release
branch
7 times, most recently
from
dabcb82 to
916fcbe
Compare
macno
commented
Mar 13, 2024
.github/workflows/node-test.yml
Outdated
| steps: | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Login to Docker Hub |
There was a problem hiding this comment.
I'd condition publishing to docker hub too
There was a problem hiding this comment.
It is indeed conditioned to the ref being a tag. Do you mean we also want a PUBLISH_DH flag?
There was a problem hiding this comment.
yes sorry, I meant in the same way we already do for GHC
macno
force-pushed
the
first-release
branch
2 times, most recently
from
db6d1db to
669a780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.