Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dart version, migrate deprecations, resolve formatting blocker #255

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 6, 2024

In another PR, the formatter was complaining in CI.
This change updates the packages to the latest version of Dart and fixes the formatting issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks
Copy link
Contributor Author

Piinks commented Dec 6, 2024

This appears to be more complicated than I thought. Local formatting yields a different result than CI.
Will close for now while I investigate further, the new formatter is likely getting mixed up in here somewhere.

@Piinks Piinks closed this Dec 6, 2024
@Piinks Piinks reopened this Dec 6, 2024
@Piinks
Copy link
Contributor Author

Piinks commented Dec 6, 2024

I think I found it

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2024
Copy link

auto-submit bot commented Dec 6, 2024

auto label is removed for flutter/assets-for-api-docs/255, due to - The status or check suite Test Assets for APIs has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor Author

Piinks commented Dec 6, 2024

Thanks @domesticmouse!

@Piinks Piinks changed the title Fix formatting issue in ci Update Dart version, migrate deprecations, resolve formatting blocker Dec 6, 2024
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2024
@auto-submit auto-submit bot merged commit 32d0c0c into flutter:main Dec 6, 2024
2 checks passed
@goderbauer
Copy link
Member

Local formatting yields a different result than CI.

For future archeologists, the reason for this buggy behavior is dart-lang/dart_style#1617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants