Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License update - Batch 15 #8693

Merged
merged 3 commits into from
Jan 13, 2025
Merged

License update - Batch 15 #8693

merged 3 commits into from
Jan 13, 2025

Conversation

mossmana
Copy link
Contributor

Updates the license headers for:

  1. packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart
  2. packages/devtools_app/lib/src/screens/debugger/breakpoints.dart
  3. packages/devtools_app/lib/src/screens/debugger/call_stack.dart
  4. packages/devtools_app/lib/src/screens/debugger/codeview.dart
  5. packages/devtools_app/lib/src/screens/debugger/codeview_controller.dart
  6. packages/devtools_app/lib/src/screens/debugger/common.dart
  7. packages/devtools_app/lib/src/screens/debugger/controls.dart
  8. packages/devtools_app/lib/src/screens/debugger/debugger_controller.dart
  9. packages/devtools_app/lib/src/screens/debugger/debugger_model.dart
  10. packages/devtools_app/lib/src/screens/debugger/debugger_screen.dart
  11. packages/devtools_app/lib/src/screens/debugger/file_search.dart
  12. packages/devtools_app/lib/src/screens/debugger/key_sets.dart
  13. packages/devtools_app/lib/src/screens/debugger/program_explorer.dart
  14. packages/devtools_app/lib/src/screens/debugger/program_explorer_controller.dart
  15. packages/devtools_app/lib/src/screens/debugger/program_explorer_model.dart
  16. packages/devtools_app/lib/src/screens/debugger/span_parser.dart
  17. packages/devtools_app/lib/src/screens/debugger/syntax_highlighter.dart
  18. packages/devtools_app/lib/src/screens/debugger/variables.dart
  19. packages/devtools_app/test/screens/debugger/association_variable_test.dart
  20. packages/devtools_app/test/screens/debugger/debugger_codeview_statistics_test.dart
  21. packages/devtools_app/test/screens/debugger/debugger_codeview_test.dart
  22. packages/devtools_app/test/screens/debugger/debugger_console_test.dart
  23. packages/devtools_app/test/screens/debugger/debugger_controller_test.dart
  24. packages/devtools_app/test/screens/debugger/debugger_controller_stdio_test.dart
  25. packages/devtools_app/test/screens/debugger/debugger_evaluation_test.dart
  26. packages/devtools_app/test/screens/debugger/debugger_floating_test.dart
  27. packages/devtools_app/test/screens/debugger/debugger_screen_breakpoints_test.dart
  28. packages/devtools_app/test/screens/debugger/debugger_screen_call_stack_test.dart
  29. packages/devtools_app/test/screens/debugger/debugger_screen_dap_variables_test.dart
  30. packages/devtools_app/test/screens/debugger/debugger_screen_explorer_visibility_test.dart
  31. packages/devtools_app/test/screens/debugger/debugger_screen_paused_test.dart
  32. packages/devtools_app/test/screens/debugger/debugger_screen_test.dart
  33. packages/devtools_app/test/screens/debugger/debugger_screen_variables_test.dart
  34. packages/devtools_app/test/screens/debugger/debugger_scripts_test.dart
  35. packages/devtools_app/test/screens/debugger/eval_field_test.dart
  36. packages/devtools_app/test/screens/debugger/file_search_test.dart
  37. packages/devtools_app/test/screens/debugger/program_explorer_test.dart
  38. packages/devtools_app/test/screens/debugger/records_variable_test.dart
  39. packages/devtools_app/test/screens/debugger/span_parser_test.dart
  40. packages/devtools_app/test/screens/debugger/syntax_highlighter_test.dart
  41. packages/devtools_app/test/screens/debugger/typed_data_variable_test.dart
  42. packages/devtools_app/test/screens/debugger/variables_test.dart

#8216

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

@mossmana mossmana marked this pull request as ready for review January 13, 2025 18:29
@mossmana mossmana requested a review from elliette as a code owner January 13, 2025 18:29
kenzieschmoll
kenzieschmoll reviewed Jan 13, 2025
View reviewed changes
packages/devtools_app/lib/src/screens/debugger/syntax_highlighter.dart Outdated
Comment on lines 1 to 6
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright 2021 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this header didn't update properly. The old header is still there

Copy link
Contributor Author

@mossmana mossmana Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case it is because the original header was missing a period at the end. The tool is using exact not fuzzy matching to reduce lookahead performance issues.

kenzieschmoll
kenzieschmoll approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once duplicate header is removed

@mossmana mossmana merged commit 85d3b95 into flutter:master Jan 13, 2025
24 checks passed
@mossmana mossmana deleted the 8216-batch15 branch January 13, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@elliette elliette Awaiting requested review from elliette elliette is a code owner

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmana @kenzieschmoll