Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Property Editor] Handle null text document / text document version in ActiveLocationChangedEvent #8781

Merged
merged 3 commits into from
Jan 17, 2025
Merged

[Property Editor] Handle null text document / text document version in ActiveLocationChangedEvent #8781

merged 3 commits into from
Jan 17, 2025

Conversation

elliette
Copy link
Member

@elliette elliette commented Jan 17, 2025 •
edited
Loading

Fixes #8704, #8745
Work towards #1948

  • In the ActiveLocationChangedEvent, the text document can be null
  • In the text document, the version can also be null

@elliette elliette requested a review from a team as a code owner January 17, 2025 00:41
@elliette elliette requested review from kenzieschmoll and removed request for a team January 17, 2025 00:41
@elliette elliette changed the title [Property Editor] Handle null text document in ActiveLocationChangedEvent [Property Editor] Handle null text document / text document version in ActiveLocationChangedEvent Jan 17, 2025
@elliette elliette merged commit 8c7fc3f into flutter:master Jan 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when opening DevTools in VS Code
2 participants
@elliette @kenzieschmoll