Skip to content

Commit

Permalink
Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) (#56407)
Browse files Browse the repository at this point in the history
Redo #56401 with a manual license change to remove the chromeos/icudtl.dat.hash. The file was removed by https://crrev.com/83a7bd47a345137ac6081c71c2a7158f5403cd30.

Original change description:

https://chromium.googlesource.com/chromium/deps/icu.git/+log/9408c6fd4a39..4239b1559d11

2024-10-02 [[email protected]](mailto:[email protected]) Updated TZ to 2024b
2024-09-05 [[email protected]](mailto:[email protected]) Remove icudtl.dat.hash

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC [[email protected]](mailto:[email protected]),[[email protected]](mailto:[email protected]) on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
  • Loading branch information
zijiehe-google-com authored Nov 6, 2024
1 parent 3df1546 commit eec1ba4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ deps = {
Var('chromium_git') + '/external/github.com/google/flatbuffers' + '@' + '0a80646371179f8a7a5c1f42c31ee1d44dcf6709',

'src/flutter/third_party/icu':
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '9408c6fd4a39e6fef0e1c4077602e1c83b15f3fb',
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '4239b1559d11d4fa66c100543eda4161e060311e',

'src/flutter/third_party/gtest-parallel':
Var('chromium_git') + '/external/github.com/google/gtest-parallel' + '@' + '38191e2733d7cbaeaef6a3f1a942ddeb38a2ad14',
Expand Down
1 change: 0 additions & 1 deletion ci/licenses_golden/licenses_flutter
Original file line number Diff line number Diff line change
Expand Up @@ -59084,7 +59084,6 @@ FILE: ../../../flutter/third_party/icu/android/icudtl.dat
FILE: ../../../flutter/third_party/icu/cast/brkitr.patch
FILE: ../../../flutter/third_party/icu/cast/icudtl.dat
FILE: ../../../flutter/third_party/icu/chromeos/icudtl.dat
FILE: ../../../flutter/third_party/icu/chromeos/icudtl.dat.hash
FILE: ../../../flutter/third_party/icu/common/icudtb.dat
FILE: ../../../flutter/third_party/icu/common/icudtl.dat
FILE: ../../../flutter/third_party/icu/flutter/brkitr.patch
Expand Down

0 comments on commit eec1ba4

Please sign in to comment.