Pub workspace-ify most of testing/ and parts of tools/
#54124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
changed the title
testing/ and parts of tools/
|
The With the workspace, the analyzer will resolve (Without the workspace the analyzer was obtaining the path for CI is having issues analyzing the |
Not quite, I think I just need to tweak dependency overrides. |
|
Ok looks fine locally, PTAL @jason-simmons. |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2024
…152414) flutter/engine@e28f875...0c5504e 2024-07-26 [email protected] [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 [email protected] Revert "[Impeller] Use downsample shader for blur instead of mip levels. (#53760)" (flutter/engine#54148) 2024-07-26 [email protected] Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 [email protected] Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 [email protected] Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152414) flutter/engine@e28f875...0c5504e 2024-07-26 [email protected] [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 [email protected] Revert "[Impeller] Use downsample shader for blur instead of mip levels. (flutter#53760)" (flutter/engine#54148) 2024-07-26 [email protected] Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 [email protected] Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 [email protected] Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152414) flutter/engine@e28f875...0c5504e 2024-07-26 [email protected] [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 [email protected] Revert "[Impeller] Use downsample shader for blur instead of mip levels. (flutter#53760)" (flutter/engine#54148) 2024-07-26 [email protected] Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 [email protected] Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 [email protected] Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces and closes #53997.
This PR migrates the following packages to the pub workspace:
It also makes minor changes to the Dart build rules in order to resolve the root package_config, instead of per-package.
I am not totally confident of the
_embedder.yamlchange, but I also can't explain what is needed to continue analyzinglib/uiwithout analysis failures that all of the symbols indart:nativewrappersare missing.