Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextInput] Add TextInputType.webSearch (#15762) #56428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stonemaster
Copy link

@stonemaster stonemaster commented Nov 7, 2024

This PR adds the engine part to add TextInputType.webSearch that allows to show a keyboard with ready access to a "." key on iOS. On Android this is re-mapped to url which shows the same behaviour as webSearch on iOS. This fixes issue flutter/flutter#157562.

The flutter PR: flutter/flutter#158323

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ small nit.

@stonemaster
Copy link
Author

I added a new testcase 🎉

@stonemaster stonemaster reopened this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants