Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[in_app_purchase_storekit] Add Swift Package Manager compatibility #8469
base: main
Are you sure you want to change the base?
[in_app_purchase_storekit] Add Swift Package Manager compatibility #8469
Changes from all commits
9667994
7f39afd
f89ba52
046cfb7
6f3f861
2c0cff2
f415bf0
800d979
67707f0
1598e95
98fc8cf
c512d41
c6fbc72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? If I remove this line, I can still build fine locally using both SwiftPM and CocoaPods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am encountering errors when running the project on macOS using the SPM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really weird but I'm able to reproduce this on my machine as well... This seems harmless I guess 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add the missing
Foundation
import (this header usesNSArray
for instance), this probably won't be necessary. Usually this header doesn't have to be explicitly imported because the core frameworks all use it in their headers. (Arguably it should be included anyway for IWYU, but it's kind of a grey area since it's so core.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alejandro-all-win-software Could you try Stuart's suggestion of replacing#include <TargetConditionals.h>
with#import <Foundation/Foundation.h>
?Edit: Upon re-reading Stuart's comment, I think we should keep the
TargetConditionals
import unless we also importFoundation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I replace#include <TargetConditionals.h>
with#import <Foundation/Foundation.h>
instead?Oops, I didn’t look at the previous response 😅.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited my comment after a few minutes, sorry for the confusion! 😅