-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable rfw tests #415
base: main
Are you sure you want to change the base?
Re-enable rfw tests #415
Conversation
dc201c0
to
3ec489c
Compare
I don't think this can land until the failing presubmits are addressed. |
Looking into the failing tests. |
3ec489c
to
4ce9328
Compare
Could the workflow be run please? To see if the failure is still happening. |
@victoreronmosele Could you resolve the merge conflicts? If you push a new commit that will also rerun all the tests. Thank you! |
@goderbauer I'll get on it. |
b740197
to
fc04645
Compare
fc04645
to
fff8db8
Compare
Hi @goderbauer, I'm seeing a "Merge is not an allowed merge method in this repository." message after pushing the commit. Do I still need to do anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No, I just need to find a secondary reviewer and then we should be able to land this. |
LGTM! We'll need to update the pinned version in flutter/flutter after this lands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, sorry, double checking... shouldn't the commit here be updated to include the change from flutter/packages#7148 that fixed this?
It looks like that change landed at
3890ceef72e140bc30cdeca59e0c70721f476fba
but this file checks out
0891835f8341b5c7bcd9d035a8d9c6b0f0039034
@Piinks the change was made in the packages repo. Is there a way to include it here? |
Yes, the file you are renaming specifies which commit from flutter/packages to checkout. :) |
Thanks! Will update the file. |
Updated the commit in the file. |
This PR re-enables the
rfw
tests disabled in #386.The
rfw
tests were fixed in flutter/packages#7148.Closes flutter/flutter#151659.