Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable rfw tests #415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victoreronmosele
Copy link

This PR re-enables the rfw tests disabled in #386.

The rfw tests were fixed in flutter/packages#7148.

Closes flutter/flutter#151659.

@zanderso
Copy link
Member

I don't think this can land until the failing presubmits are addressed.

@victoreronmosele
Copy link
Author

Looking into the failing tests.

@victoreronmosele
Copy link
Author

Could the workflow be run please? To see if the failure is still happening.

@goderbauer
Copy link
Member

@victoreronmosele Could you resolve the merge conflicts? If you push a new commit that will also rerun all the tests. Thank you!

@victoreronmosele
Copy link
Author

@goderbauer I'll get on it.

@victoreronmosele victoreronmosele force-pushed the re-enable_rfw_tests branch 2 times, most recently from b740197 to fc04645 Compare February 5, 2025 01:26
@victoreronmosele
Copy link
Author

Hi @goderbauer, I'm seeing a "Merge is not an allowed merge method in this repository." message after pushing the commit.

Do I still need to do anything else?

goderbauer
goderbauer previously approved these changes Feb 5, 2025
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

Do I still need to do anything else?

No, I just need to find a secondary reviewer and then we should be able to land this.

@goderbauer goderbauer requested a review from Piinks February 5, 2025 17:19
@Piinks
Copy link
Contributor

Piinks commented Feb 5, 2025

LGTM! We'll need to update the pinned version in flutter/flutter after this lands

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, sorry, double checking... shouldn't the commit here be updated to include the change from flutter/packages#7148 that fixed this?

It looks like that change landed at
3890ceef72e140bc30cdeca59e0c70721f476fba
but this file checks out
0891835f8341b5c7bcd9d035a8d9c6b0f0039034

@victoreronmosele
Copy link
Author

@Piinks the change was made in the packages repo. Is there a way to include it here?

@Piinks
Copy link
Contributor

Piinks commented Feb 5, 2025

Yes, the file you are renaming specifies which commit from flutter/packages to checkout. :)

@victoreronmosele
Copy link
Author

Thanks! Will update the file.

@victoreronmosele
Copy link
Author

Updated the commit in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and re-enable rfw tests
4 participants