Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide for new Material 3 Slider shapes #11093

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TahaTesser
Copy link
Member

Related to flutter/flutter#152237

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@TahaTesser TahaTesser changed the title Slider shapes guide Migration guide for new Material 3 Slider shapes Aug 30, 2024
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Aug 30, 2024

Visit the preview URL for this PR (updated for commit 61c185f):

https://flutter-docs-prod--pr11093-slider-shapes-guide-r3oa68rq.web.app

## Migration guide

You automatically get the new `Slider` shapes and color mappings.
To use the previous `Slider` shapes and color mappings, set the following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is going through the theme the only option? Can folks configure directly on Slider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme only. There are too many slider components parameters so looks like they weren't passed to Slider directly.

Copy link
Contributor

@Piinks Piinks Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, working with some customer that are affected by this, some of them don't like having to insert a theme to maintain backwards compatibility.
How many properties would be exposed on Slider in order to achieve backwards compatibility?

Copy link
Member Author

@TahaTesser TahaTesser Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much all of them, otherwise they would be inconsistent.

If necessary, what about if introduce single customization parameter in the Slider widget that take all of the Slider components and customizes the Slider. Something like TextStyle, AnimationStyle, we could've SliderStyle?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is also a really good idea!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like that is better than a bunch of new constructors, let's give it a try and see how it looks. I trust your assessment of the two options. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants