Declare package:flutter_gen to be deprecated
#11343
Merged
+95
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
requested review from
sfshaza2,
parlough and
a team
as code owners
matanlurey
changed the title
package:flutter_gen to be deprecated
jonahwilliams
approved these changes
Oct 30, 2024
src/content/release/breaking-changes/flutter-generate-i10n-source.md
Outdated
Show resolved
Hide resolved
cbracken
reviewed
Oct 30, 2024
src/content/release/breaking-changes/flutter-generate-i10n-source.md
Outdated
Show resolved
Hide resolved
cbracken
approved these changes
Oct 30, 2024
…rce.md Co-authored-by: Jonah Williams <[email protected]>
…rce.md Co-authored-by: Chris Bracken <[email protected]>
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 31, 2024
…157879) Work towards #157819. **No behavior changes as a result of this PR**. Based on a proof of concept by @jonahwilliams (#157818). The existence of this flag (which for the time being, defaults to `true`) implies the following: 1. The (legacy, deprecated) `.flutter-plugins` file is not generated: https://docs.flutter.dev/release/breaking-changes/flutter-plugins-configuration 2. The (legacy, deprecated) `package:flutter_gen` is not synthetically generated: flutter/website#11343 (awaiting website approvers, but owners approve this change) This change creates `useImplicitPubspecResolution` and plumbs it through as a required variable, parsing it from a `FlutterCommand.globalResults` where able. In tests, I've defaulted the value to `true` 100% of the time - except for places where the value itself is acted on directly, in which case there are true and false test-cases (e.g. localization and i10n based classes and functions). I'm not extremely happy this needed to change 50+ files, but is sort of a result of how inter-connected many of the elements of the tools are. I believe keeping this as an explicit (flagged) argument will be our best way to ensure the default behavior changes consistently and that tests are running as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare the
package:flutter_genapproach deprecated and explain the current migration path.Part of flutter/flutter#157819, flutter/flutter#102983.
/cc @andrewkolos