Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Build a web app with Flutter" page #11363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Nov 5, 2024

This updates the "Build a web app with Flutter" page by simplifying the steps, adding Wasm information, removing references to the out-of-date --enable-web flag, and moving some relevant info on debugging and testing from the FAQ.

cc: @kevmoo

Resolves #11318

@johnpryan johnpryan requested review from sfshaza2, parlough and a team as code owners November 5, 2024 20:54
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit b81c512):

https://flutter-docs-prod--pr11363-issue-11318-build-web-rj583nay.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments/feedback. But I do have a question about some text you deleted from the faq. But that's not enough to hold this up.

* Run a new project with web support.
* Build an app with web support.
* Add web support to an existing project.
This page provides an overview of how to configure, run and build a web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make me lecture you on the Oxford comma!

Suggested change
This page provides an overview of how to configure, run and build a web
This page provides an overview of how to configure, run, and build a web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an honest mistake I swear!

```

In your IDE, you should see **Chrome (web)** in the device pulldown.
This will create a `web/` directory containing the web assets used to bootstrap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will create a `web/` directory containing the web assets used to bootstrap
This creates a `web/` directory containing the web assets used to bootstrap


#### Command line
You can also use the `edge` device type on Windows, or use `web-server` to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also use the `edge` device type on Windows, or use `web-server` to
If you prefer, you can use the `edge` device type on Windows, or use `web-server` to

Trying to avoid "You can also" in two consecutive lines of text.

@@ -112,25 +112,6 @@ See [Embedding Flutter web][].

See [Web content in Flutter][].

### How do I debug a web app?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this advice just wrong now?

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.await-update Awaiting Updates after Edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Build a web app with Flutter" page
3 participants