Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): show blank icon if no adaptive icon set #601

Merged

Conversation

chungxon
Copy link
Contributor

Fixes #578, #579, #585, #589, #594, #595, #600

In the new version 0.14.1, not everyone specified adaptive_icon_background and adaptive_icon_foreground or adaptive_icon_monochrome in their Android configuration, so the app icon may be black/blank after generating.

As suggested by #579 (comment), you can delete the android/app/src/main/res/mipmap-anydpi-v26/${androidIconName}.xml file after running generating to solve this issue.

However, it will still always create this file. I think this file should only be created if any configuration related to adaptive icons is set up.

@chungxon

This comment was marked as resolved.

chungxon added a commit to chungxon/flutter_app_customizer that referenced this pull request Oct 13, 2024
@mw108
Copy link

mw108 commented Oct 14, 2024

Can confirm it works. Specifying adaptive_icon_background and adaptive_icon_foreground in either the pubspec.yaml or flutter_launcher_icons.yaml and regenerating the launcher icons via dart run flutter_launcher_icons solves the problem.

@xShuusui
Copy link

Would also fix #613 #611

Copy link
Contributor

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However, I'm not a maintainer. @MarkOSullivan94 can you have a look?

@jkoenig134
Copy link

This is an important fix, I have to delete the falsely generated file every time I want to re-generate my icons. @MarkOSullivan94 could you have a look?

@MarkOSullivan94
Copy link
Collaborator

Thank you for this fix @chungxon

Thank you @jkoenig134 for pinging me to get this merged

I'll get another release shipped shortly with this in it and hopefully this will help you @jkoenig134

Copy link
Collaborator

@MarkOSullivan94 MarkOSullivan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkOSullivan94 MarkOSullivan94 merged commit 50b058c into fluttercommunity:master Jan 17, 2025
@jkoenig134
Copy link

@MarkOSullivan94 thank you! This will close so many issues here 🎉

@MarkOSullivan94
Copy link
Collaborator

@jkoenig134 published v0.14.3 - should be available in the next 10 minutes or so

@MarkOSullivan94
Copy link
Collaborator

Thanks everyone for bringing the issues to my attention which this PR fixes, if I've missed any please reply and let me know which ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Android: Black app launcher icon
6 participants