-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Android): show blank icon if no adaptive icon set #601
fix(Android): show blank icon if no adaptive icon set #601
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Can confirm it works. Specifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
However, I'm not a maintainer. @MarkOSullivan94 can you have a look?
This is an important fix, I have to delete the falsely generated file every time I want to re-generate my icons. @MarkOSullivan94 could you have a look? |
Thank you for this fix @chungxon Thank you @jkoenig134 for pinging me to get this merged I'll get another release shipped shortly with this in it and hopefully this will help you @jkoenig134 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MarkOSullivan94 thank you! This will close so many issues here 🎉 |
@jkoenig134 published v0.14.3 - should be available in the next 10 minutes or so |
Thanks everyone for bringing the issues to my attention which this PR fixes, if I've missed any please reply and let me know which ones |
Fixes #578, #579, #585, #589, #594, #595, #600
In the new version 0.14.1, not everyone specified
adaptive_icon_background
andadaptive_icon_foreground
oradaptive_icon_monochrome
in their Android configuration, so the app icon may be black/blank after generating.As suggested by #579 (comment), you can delete the
android/app/src/main/res/mipmap-anydpi-v26/${androidIconName}.xml
file after running generating to solve this issue.However, it will still always create this file. I think this file should only be created if any configuration related to adaptive icons is set up.