8.0.0-pre-4

fluttercommunity · Jun 3, 2024 · f536845 · f536845
1 parent 036d16d
commit f536845
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
+## [8.0.0-pre-4] - 03.06.2024 fixing bug in `unregister` that happened if you tried to unregister a named registration by providing an istance instead of the type and the instance name
 ## [8.0.0-pre-3] - 31.05.2024 releaseInstance will now throw if the instance isn't registered
 ## [8.0.0-pre-2] - 29.05.2024 fixing negitiv reference count
 ## [8.0.0-pre-1] - 26.05.2024 

diff --git a/lib/get_it_impl.dart b/lib/get_it_impl.dart
@@ -1010,8 +1010,8 @@ class _GetItImplementation implements GetIt {
     }
     final typeRegistration = factoryToRemove.registeredIn;
 
-    if (instanceName != null) {
-      typeRegistration.namedFactories.remove(instanceName);
+    if (factoryToRemove.isNamedRegistration) {
+      typeRegistration.namedFactories.remove(factoryToRemove.instanceName);
     } else {
       typeRegistration.factories.remove(factoryToRemove);
     }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: get_it
 description: Simple direct Service Locator that allows to decouple the interface from a concrete implementation and  to access the concrete implementation from everywhere in your App"
-version: 8.0.0-pre-3
+version: 8.0.0-pre-4
 maintainer: Thomas Burkhart (@escamoteur)
 homepage: https://github.com/fluttercommunity/get_it
 funding: