Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unregister only with type without named #360

Closed
wants to merge 1 commit into from
Closed

fix: unregister only with type without named #360

wants to merge 1 commit into from

Conversation

venkata-reddy-dev
Copy link
Contributor

This PR fixes issue #358 and added respective test case for same.

@spydon please verify your code with this fix and confirm.

 get_it:
    git:
      url: https://github.com/venkata-reddy-dev/get_it
      ref: issue_358

@escamoteur please review the changes.

spydon
spydon approved these changes Apr 11, 2024
View reviewed changes
Copy link

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried this from ubuntu_service and it does indeed solve the regresssion, thanks!

@escamoteur
Copy link
Collaborator

Thanks for testing. I have already made the changes in my code base, so I will not merge this PR but push my changes

@escamoteur escamoteur closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venkata-reddy-dev @escamoteur @spydon