Skip to content

Commit

Permalink
Fix lints, melos run format (#1102)
Browse files Browse the repository at this point in the history
  • Loading branch information
nohli authored Sep 28, 2022
1 parent 8107c4a commit 7b6eae2
Show file tree
Hide file tree
Showing 12 changed files with 23 additions and 27 deletions.
1 change: 1 addition & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#
# include: ../../analysis_options.yaml
#

include: package:flutter_lints/flutter.yaml

analyzer:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import 'dart:io';

import 'package:battery_plus/battery_plus.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
// found in the LICENSE file.

import 'dart:io';
import 'package:integration_test/integration_test.dart';
import 'package:flutter_test/flutter_test.dart';

import 'package:connectivity_plus/connectivity_plus.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';

void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();

group('Connectivity test driver', () {
Connectivity _connectivity;
ConnectivityResult _connectionStatusExpected = ConnectivityResult.wifi;

setUpAll(() async {
_connectivity = Connectivity();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,18 @@ class NetworkInformationApiConnectivityPlugin extends ConnectivityPlusPlugin {

/// periodically checks the current network state
Stream<ConnectivityResult> _webPseudoStream() {
final StreamController<ConnectivityResult> _webStream =
final StreamController<ConnectivityResult> webStream =
StreamController.broadcast();
Timer.periodic(
const Duration(milliseconds: 250),
(timer) async {
final result = await checkConnectivity();
if (result != _lastFallbackState) {
_webStream.add(result);
webStream.add(result);
}
},
);
return _webStream.stream;
return webStream.stream;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@ import 'package:device_info_plus_platform_interface/model/macos_device_info.dart
import 'package:plugin_platform_interface/plugin_platform_interface.dart';

import 'method_channel/method_channel_device_info.dart';

import 'model/android_device_info.dart';
import 'model/ios_device_info.dart';
import 'model/linux_device_info.dart';
import 'model/macos_device_info.dart';
import 'model/web_browser_info.dart';
import 'model/windows_device_info.dart';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class MyHomePage extends StatefulWidget {
final String? title;

@override
_MyHomePageState createState() => _MyHomePageState();
State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ dev_dependencies:
flutter_driver:
sdk: flutter
flutter_lints: ^2.0.1
flutter_test:
sdk: flutter

flutter:
uses-material-design: true
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ class _FileVersionInfo {
];

String? value;
final Pointer<IntPtr>? lplpBuffer = calloc<IntPtr>();
final Pointer<Uint32>? puLen = calloc<Uint32>();
final Pointer<IntPtr> lplpBuffer = calloc<IntPtr>();
final Pointer<Uint32> puLen = calloc<Uint32>();

String toHex4(int val) => val.toRadixString(16).padLeft(4, '0');

Expand All @@ -69,7 +69,7 @@ class _FileVersionInfo {
final codepage = toHex4(langCodepage[1]!);
final lpSubBlock = TEXT('\\StringFileInfo\\$lang$codepage\\$name');
final res =
VerQueryValue(_data.lpBlock!, lpSubBlock, lplpBuffer!.cast(), puLen!);
VerQueryValue(_data.lpBlock!, lpSubBlock, lplpBuffer.cast(), puLen);
calloc.free(lpSubBlock);

if (res != 0 && lplpBuffer.value != 0 && puLen.value > 0) {
Expand All @@ -79,8 +79,8 @@ class _FileVersionInfo {
}
}

calloc.free(lplpBuffer!);
calloc.free(puLen!);
calloc.free(lplpBuffer);
calloc.free(puLen);
return value;
}

Expand Down
6 changes: 3 additions & 3 deletions packages/sensors_plus/sensors_plus/test/sensors_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ void main() {
void _initializeFakeSensorChannel(String channelName, List<double> sensorData) {
const standardMethod = StandardMethodCodec();

void _emitEvent(ByteData? event) {
void emitEvent(ByteData? event) {
ServicesBinding.instance.defaultBinaryMessenger.handlePlatformMessage(
channelName,
event,
Expand All @@ -75,8 +75,8 @@ void _initializeFakeSensorChannel(String channelName, List<double> sensorData) {
.setMockMessageHandler(channelName, (ByteData? message) async {
final methodCall = standardMethod.decodeMethodCall(message);
if (methodCall.method == 'listen') {
_emitEvent(standardMethod.encodeSuccessEnvelope(sensorData));
_emitEvent(null);
emitEvent(standardMethod.encodeSuccessEnvelope(sensorData));
emitEvent(null);
return standardMethod.encodeSuccessEnvelope(null);
} else if (methodCall.method == 'cancel') {
return standardMethod.encodeSuccessEnvelope(null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void main() {
void _initializeFakeSensorChannel(String channelName, List<double> sensorData) {
const standardMethod = StandardMethodCodec();

void _emitEvent(ByteData? event) {
void emitEvent(ByteData? event) {
ServicesBinding.instance.defaultBinaryMessenger.handlePlatformMessage(
channelName,
event,
Expand All @@ -98,8 +98,8 @@ void _initializeFakeSensorChannel(String channelName, List<double> sensorData) {
.setMockMessageHandler(channelName, (ByteData? message) async {
final methodCall = standardMethod.decodeMethodCall(message);
if (methodCall.method == 'listen') {
_emitEvent(standardMethod.encodeSuccessEnvelope(sensorData));
_emitEvent(null);
emitEvent(standardMethod.encodeSuccessEnvelope(sensorData));
emitEvent(null);
return standardMethod.encodeSuccessEnvelope(null);
} else if (methodCall.method == 'cancel') {
return standardMethod.encodeSuccessEnvelope(null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
// found in the LICENSE file.

import 'dart:async';
import 'dart:ui';

import 'package:flutter/services.dart';
import 'package:meta/meta.dart' show visibleForTesting;
import 'package:mime/mime.dart' show lookupMimeType;

import 'package:share_plus_platform_interface/share_plus_platform_interface.dart';

/// Plugin for summoning a platform share sheet.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,15 @@
// found in the LICENSE file.

import 'dart:io';
import 'dart:ui';

import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart'
show TestDefaultBinaryMessengerBinding, TestWidgetsFlutterBinding;
import 'package:mockito/mockito.dart';
import 'package:share_plus_platform_interface/share_plus_platform_interface.dart';
import 'package:share_plus_platform_interface/method_channel/method_channel_share.dart';
import 'package:share_plus_platform_interface/share_plus_platform_interface.dart';
import 'package:test/test.dart';

import 'package:flutter/services.dart';

void main() {
TestWidgetsFlutterBinding.ensureInitialized();

Expand Down

0 comments on commit 7b6eae2

Please sign in to comment.