Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): Fix deprecation warning on MacOS #2377

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

EchoEllet
Copy link
Contributor

Description

Fix macOS warning for device_info_plus

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@EchoEllet EchoEllet changed the title Fix macOS warning for device_info_plus fix: Fix macOS warning for device_info_plus Nov 12, 2023
@EchoEllet
Copy link
Contributor Author

image
I didn't get any build failure in my local machine

EchoEllet and others added 2 commits November 15, 2023 19:11
…mUUID.swift


Add support for older versions of macOS

Co-authored-by: Nico Mexis <[email protected]>
@EchoEllet
Copy link
Contributor Author

EchoEllet commented Nov 15, 2023

We're ready to review the change.

@vbuberen vbuberen changed the title fix: Fix macOS warning for device_info_plus fix(device_info_plus): Fix deprecation warning on MacOS Nov 17, 2023
@vbuberen vbuberen merged commit 56a6d0f into fluttercommunity:main Nov 17, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Warrning on macOS for device_info_plus plugin
4 participants