fix(device_info_plus)!: Remove Display Metrics from Android Device Info

[miquelbeltran]

Description

Following the discussion in #2688 (comment)

• Display Metrics on Android depend on the Activity context and should not be obtained from the Application context.
• This means that Flutter applications that use this plugin would require that they are attached to an Activity.
• Plugin users can use better methods to obtain display information, e.g. MediaQuery DisplayFeature: https://api.flutter.dev/flutter/dart-ui/DisplayFeature-class.html that also support multiple displays, foldables, etc.
• To keep this plugin independent of the Android Activity lifecycle, I remove the Display Metrics part from the Android device info, instead users should use MediaQuery.

Related Issues

• Replaces: fix(device_info_plus): Ensure use of Activity Context to obtain WindowManager #2688
• Closes [Bug]: device_info_plus violates Android StrictMode's IncorrectContextUseViolation #2687

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I titled the PR using Conventional Commits.
• I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
• All existing and new tests are passing.
• The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
• No, this is not a breaking change.

[miquelbeltran]

@ChristianEdwardPadilla fyi, please comment on this.

[vbuberen]

Good that you mentioned about the DisplayFeature API as I wanted to share it as well :)

I am Ok with dropping this data from the plugin.

[ChristianEdwardPadilla]

LGTM. Thanks the quick turnaround on all this!

[alexyuyl]

Hi, thanks for the work. Personally I used the device metric to obtain Android device physical info as below before the change:

Map<String, dynamic> _readAndroidBuildData(AndroidDeviceInfo build) { return <String, dynamic> { 'displayWidthPixels': build.displayMetrics.widthPx, 'displayWidthInches': build.displayMetrics.widthInches, 'displayHeightPixels': build.displayMetrics.heightPx, 'displayHeightInches': build.displayMetrics.heightInches }; }

This was in hope to accurately replicate physical distance on screen using pixel counts. Now that the plugin no longer support the features, what is the alternative way to obtain the number of pixels in both height and width on a screen, and the actual length and width of the device in real world? Thank you.

[miquelbeltran]

There are packages that implement this functionality, also support all platforms and not just Android. e.g. https://github.com/benthillerkus/millimeters