Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): fix the error in the e2e test. #3382

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

StanleyCocos
Copy link
Contributor

I'm not sure why this part is hardcoded. But if we do it this way, it means our local tests might not pass.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

Thanks! I think it is a valid compromise indeed.

@miquelbeltran miquelbeltran merged commit 3d06bf0 into fluttercommunity:main Dec 7, 2024
18 of 20 checks passed
@StanleyCocos StanleyCocos deleted the fix/test_info branch December 9, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants