-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connectivity_plus): A bug fix in run dependency on mac and projects #3387
Conversation
update gradle version
change version distributionUrl
@@ -8,7 +8,7 @@ buildscript { | |||
} | |||
|
|||
dependencies { | |||
classpath 'com.android.tools.build:gradle:8.3.1' | |||
classpath 'com.android.tools.build:gradle:8.3.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make any sense, because 8.3.1 also a valid version if you check releases of the AGP: https://mvnrepository.com/artifact/com.android.tools.build/gradle
@@ -1,5 +1,5 @@ | |||
distributionBase=GRADLE_USER_HOME | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you don't know what is the difference between bin
and all
, since it is definitely doesn't change anything about the problem you described in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check for valid distributions here, which, despite your claims, contains 8.4-bin
https://services.gradle.org/distributions/
As I explained in the issue already you have an issue with your local setup and logs that were provided clearly indicated the problem with dependency resolution. As this PR doesn't solve the bug, because the bug doesn't actually exist, closing this PR as it won't be accepted. |
Description
When we used this dependency in a new project on the Mac operating system, it gave errors and didn't work at all, and it didn't download anything. By changing these aspects in the dependency, the issue was easily resolved, and it became fully compatible with the other dependencies and the project.
Related Issues
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).