Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectivity_plus): A bug fix in run dependency on mac and projects #3387

Closed
wants to merge 2 commits into from

Conversation

mahanpyk
Copy link

@mahanpyk mahanpyk commented Dec 7, 2024

Description

When we used this dependency in a new project on the Mac operating system, it gave errors and didn't work at all, and it didn't download anything. By changing these aspects in the dependency, the issue was easily resolved, and it became fully compatible with the other dependencies and the project.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

update gradle version
change version distributionUrl
@mahanpyk mahanpyk changed the title Fix run dependency in mac and projects - fix: A bug fix in run dependency on mac and projects Dec 7, 2024
@mahanpyk mahanpyk changed the title - fix: A bug fix in run dependency on mac and projects fix(connectivity_plus): A bug fix in run dependency on mac and projects Dec 7, 2024
@@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:8.3.1'
classpath 'com.android.tools.build:gradle:8.3.2'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make any sense, because 8.3.1 also a valid version if you check releases of the AGP: https://mvnrepository.com/artifact/com.android.tools.build/gradle

Screenshot 2024-12-08 at 00 52 21

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you don't know what is the difference between bin and all, since it is definitely doesn't change anything about the problem you described in the issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check for valid distributions here, which, despite your claims, contains 8.4-bin
https://services.gradle.org/distributions/

Screenshot 2024-12-08 at 01 00 42

@vbuberen
Copy link
Collaborator

vbuberen commented Dec 7, 2024

As I explained in the issue already you have an issue with your local setup and logs that were provided clearly indicated the problem with dependency resolution.
From changes presented here, especially change from bin to all I assume that you are not fully aware of reason of the problem as well as what is the relation between AGP and Gradle version.
I would recommend to read https://docs.gradle.org/current/userguide/gradle_wrapper.html as it has explanation on the difference between Gradle distributions.

As this PR doesn't solve the bug, because the bug doesn't actually exist, closing this PR as it won't be accepted.

@vbuberen vbuberen closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Could not find gradle-8.3.1.jar (com.android.tools.build:gradle:8.3.1).
2 participants