Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): device memory null error on Safari and Firefox #3401

Conversation

bhaswanth-isani
Copy link
Contributor

@bhaswanth-isani bhaswanth-isani commented Dec 17, 2024

Description

Fixes type 'Null' is not a subtype of type 'double' for deviceMemory in webBrowserInfo on Safari and Firefox

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran

This comment was marked as outdated.

@miquelbeltran

This comment was marked as outdated.

@miquelbeltran
Copy link
Member

I did: dart-lang/web#326

@miquelbeltran
Copy link
Member

I added a link to the dart-lang/web report, as well as changed the return value to null instead of 0.0, as the device_info_plus field supports nullable values.

@miquelbeltran
Copy link
Member

I completely re-wrote the PR 😄 but no worries you will still be credited when merged.

@bhaswanth-isani
Copy link
Contributor Author

It's not a problem. Thanks.

@miquelbeltran miquelbeltran merged commit 2b7cb08 into fluttercommunity:main Dec 18, 2024
17 of 20 checks passed
@bhaswanth-isani bhaswanth-isani deleted the fix/web-browser-info-safari-firefox branch December 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DeviceInfoPlugin.webBrowserInfo fails locally on Safari
2 participants